Conversation
f6764d6 to
58c2109
Compare
|
Drafted to wait for Android counterpart |
dea14f2 to
838ffaf
Compare
19c5bd3 to
9371bf2
Compare
|
@piotr-iohk Another update in e2e tests needed
Otherwise PR is final and ready for review. I noticed a migration step was missing to move suggestions to widgets, added that. |
|
Could disable the Viewpager scroll when edit mode is on Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.17.12.mp4 |
|
Is this stuck behavior normal? Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.22.45.mp4 |
|
One observation while adjusting e2e. Difference between iOS and Android behavior.
Screen.Recording.2026-03-11.at.12.06.44.mov |
This comment was marked as resolved.
This comment was marked as resolved.
|
Aside these small issues, everything else looks good |
Not normal, any way to reliably reproduce? I tried on simulator and device |
I don't see why, care to explain? |
I guess |
on first page, scroll down very slowly for a good length |
To prevent change page by accident when reordering |
Doesn't reproduce for me so far ScreenRecording_03-11-2026.14-12-23_1.MP4 |
you have to scroll down, like to refresh |
|
Looks like a regression (lack of red ✔️ next to address types). Seems that ✔️ are visible in other places in Settings. Screen.Recording.2026-03-11.at.15.41.37.mov |
Fixed in c08c82f |
Will work on this in another branch, depending on the size of the changeset we can back merge here. |
Fixed in 5a5ceff |
This happens on a slow connection/offline, the refresh action never completes so the scroll view is stuck in that 'pulled down' state. I'll fix that together with the other offline fixes in another PR in a |
|
@piotr-iohk the failing e2e test doesn't seem related |
This comment was marked as resolved.
This comment was marked as resolved.
Fixed in 485b4e8 Simulator.Screen.Recording.-.iPhone.17.-.2026-03-12.at.18.36.41.mov |
* fix: rename checkmark icon * feat(home): redesign home screen * feat(widgets): convert suggestions to widget * fix(ui): allow free scroll on widgets screen * add missing ActivitySavings, ActivitySpending * fix(suggestions): add share sheet * update test id * chore: format * fix(widgets): add migration for suggestions * Suggestions test ids adjustments * fix(widgets): remove suggestions title * refactor(widgets): cleanup viewmodel code * fix(settings): address types checkmark * refactor(ui): keep HomeScreen as permanent root * fix(widgets): filter out empty suggestions widget --------- Co-authored-by: Piotr Stachyra <piotr.stachyra@gmail.com> Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
Description
Screenshots
Simulator.Screen.Recording.-.iPhone.17.-.2026-02-13.at.19.11.46.mov