Skip to content

feat: home screen redesign#442

Merged
pwltr merged 16 commits intomasterfrom
feat/home-redesign
Mar 12, 2026
Merged

feat: home screen redesign#442
pwltr merged 16 commits intomasterfrom
feat/home-redesign

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented Feb 13, 2026

Description

  • Home: Wallet (balance, activity) and Widgets (suggestions + widgets) with snap scrolling
  • Draggable list: reorder via long-press on handle only to allow scroll, fixed bugs
  • Suggestions: convert to widget and add hardware wallet card (commented out)
  • WidgetOnboardingHint: add setting and add to backup (backwards compatible)
  • Bump minimum iOS target to 17.0
  • Cleanup: removed some dead code around widgets and draggable list

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2026-02-13.at.19.11.46.mov

@pwltr pwltr force-pushed the feat/home-redesign branch from f6764d6 to 58c2109 Compare February 13, 2026 18:36
@pwltr pwltr marked this pull request as draft February 17, 2026 10:50
@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Feb 17, 2026

Drafted to wait for Android counterpart

@pwltr pwltr self-assigned this Mar 4, 2026
@pwltr pwltr force-pushed the feat/home-redesign branch from dea14f2 to 838ffaf Compare March 5, 2026 15:38
@pwltr pwltr marked this pull request as ready for review March 5, 2026 15:38
@pwltr pwltr requested review from jvsena42, ovitrif and piotr-iohk March 5, 2026 15:42
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Found 3 bugs in the changed code.

@pwltr pwltr added this to the 2.2.0 milestone Mar 9, 2026
@pwltr pwltr force-pushed the feat/home-redesign branch from 19c5bd3 to 9371bf2 Compare March 10, 2026 20:55
@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

@piotr-iohk Another update in e2e tests needed

[Bitkit.app iOS #0-0] 1) Advanced @settings_12 - Can reset suggestions
[Bitkit.app iOS #0-0] Can't call click on element with selector "~SuggestionDismiss" because element wasn't found

Otherwise PR is final and ready for review. I noticed a migration step was missing to move suggestions to widgets, added that.

@jvsena42
Copy link
Copy Markdown
Member

Could disable the Viewpager scroll when edit mode is on

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.17.12.mp4

@jvsena42
Copy link
Copy Markdown
Member

Is this stuck behavior normal?

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.22.45.mp4

@piotr-iohk
Copy link
Copy Markdown
Collaborator

One observation while adjusting e2e. Difference between iOS and Android behavior.

  • On IOS: When we are on the Widgets screen, go to settings, and come back (e.g. Burger -> Wallet, or Settings > Advanced > Reset suggestions) we are transfered back to main transaction screen.
  • on Android: we go back to Widgets screen.
    Android seems more intuitive to me 🤷‍♂️
Screen.Recording.2026-03-11.at.12.06.44.mov

@jvsena42

This comment was marked as resolved.

@jvsena42
Copy link
Copy Markdown
Member

Aside these small issues, everything else looks good

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Is this stuck behavior normal?

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.22.45.mp4

Not normal, any way to reliably reproduce? I tried on simulator and device

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Could disable the Viewpager scroll when edit mode is on

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.17.12.mp4

I don't see why, care to explain?

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Should filter out suggestions widgets when there is no suggestion

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.09.08.06.mp4

I guess SuggestionsWidget should not have a title in any case

@jvsena42
Copy link
Copy Markdown
Member

jvsena42 commented Mar 11, 2026

Not normal, any way to reliably reproduce? I tried on simulator and device

on first page, scroll down very slowly for a good length

@jvsena42
Copy link
Copy Markdown
Member

Could disable the Viewpager scroll when edit mode is on
Simulator.Screen.Recording.-.iPhone.16.-.2026-03-11.at.08.17.12.mp4

I don't see why, care to explain?

To prevent change page by accident when reordering

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Not normal, any way to reliably reproduce? I tried on simulator and device

on first page, scroll down very slowly for a good length

Doesn't reproduce for me so far

ScreenRecording_03-11-2026.14-12-23_1.MP4

@jvsena42
Copy link
Copy Markdown
Member

Not normal, any way to reliably reproduce? I tried on simulator and device

on first page, scroll down very slowly for a good length

Doesn't reproduce for me so far

ScreenRecording_03-11-2026.14-12-23_1.MP4

you have to scroll down, like to refresh

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Looks like a regression (lack of red ✔️ next to address types). Seems that ✔️ are visible in other places in Settings.
ios left / android right:

Screen.Recording.2026-03-11.at.15.41.37.mov

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Looks like a regression (lack of red ✔️ next to address types). Seems that ✔️ are visible in other places in Settings. ios left / android right:

Screen.Recording.2026-03-11.at.15.41.37.mov

Fixed in c08c82f

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

One observation while adjusting e2e. Difference between iOS and Android behavior.

  • On IOS: When we are on the Widgets screen, go to settings, and come back (e.g. Burger -> Wallet, or Settings > Advanced > Reset suggestions) we are transfered back to main transaction screen.
  • on Android: we go back to Widgets screen.
    Android seems more intuitive to me 🤷‍♂️

Screen.Recording.2026-03-11.at.12.06.44.mov

Will work on this in another branch, depending on the size of the changeset we can back merge here.

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

One observation while adjusting e2e. Difference between iOS and Android behavior.

  • On IOS: When we are on the Widgets screen, go to settings, and come back (e.g. Burger -> Wallet, or Settings > Advanced > Reset suggestions) we are transfered back to main transaction screen.
  • on Android: we go back to Widgets screen.
    Android seems more intuitive to me 🤷‍♂️

Screen.Recording.2026-03-11.at.12.06.44.mov

Will work on this in another branch, depending on the size of the changeset we can back merge here.

Fixed in 5a5ceff

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 11, 2026

Not normal, any way to reliably reproduce? I tried on simulator and device

on first page, scroll down very slowly for a good length

Doesn't reproduce for me so far
ScreenRecording_03-11-2026.14-12-23_1.MP4

you have to scroll down, like to refresh

This happens on a slow connection/offline, the refresh action never completes so the scroll view is stuck in that 'pulled down' state. I'll fix that together with the other offline fixes in another PR in a fix/offline-ui branch.

@pwltr pwltr requested a review from jvsena42 March 11, 2026 17:15
@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 12, 2026

@piotr-iohk the failing e2e test doesn't seem related

@jvsena42

This comment was marked as resolved.

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 12, 2026

Simulator.Screen.Recording.-.iPhone.16.-.2026-03-12.at.11.41.25.mp4
Suggestions padding is displayed when suggestion list is empty

Fixed in 485b4e8

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-12.at.18.36.41.mov

Copy link
Copy Markdown
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@pwltr pwltr enabled auto-merge (squash) March 12, 2026 18:20
@pwltr pwltr merged commit fe6b0a4 into master Mar 12, 2026
17 of 19 checks passed
@pwltr pwltr deleted the feat/home-redesign branch March 12, 2026 19:42
pwltr added a commit that referenced this pull request Mar 24, 2026
* fix: rename checkmark icon

* feat(home): redesign home screen

* feat(widgets): convert suggestions to widget

* fix(ui): allow free scroll on widgets screen

* add missing ActivitySavings, ActivitySpending

* fix(suggestions): add share sheet

* update test id

* chore: format

* fix(widgets): add migration for suggestions

* Suggestions test ids adjustments

* fix(widgets): remove suggestions title

* refactor(widgets): cleanup viewmodel code

* fix(settings): address types checkmark

* refactor(ui): keep HomeScreen as permanent root

* fix(widgets): filter out empty suggestions widget

---------

Co-authored-by: Piotr Stachyra <piotr.stachyra@gmail.com>
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants